Skip to content

Add information about strict_mode for encore #16207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2022

Conversation

Philosoft
Copy link
Contributor

I guess it should be both in 5.4 and 6.0, but actually will be useful down to whenever symfony/webpack-encore-bundle#54 was merged

Personally, it took me quite a long time to determine and fix the cause of functional tests failing in CI. I know that stuff is kind of mentioned in config/packages/webpack_encore.yaml, but here are my excuses

  • there is certain time gap between you first install webpack, write your functional tests (involved with actual HTML rendering), add some styles/scripts to template and setup CI to run these tests
  • this stuff is not mentioned in the docs at all - fgrep -RH strict_mode . gives 0 results

@javiereguiluz javiereguiluz changed the base branch from 6.0 to 5.4 September 22, 2022 13:24
@javiereguiluz javiereguiluz merged commit f1ac0b1 into symfony:5.4 Sep 22, 2022
@javiereguiluz
Copy link
Member

Aleksandr, thanks for this contribution and I'm sorry it took us so long to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants