Skip to content

Add missing information about tsconfig.json #16103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2021
Merged

Conversation

iquito
Copy link
Contributor

@iquito iquito commented Nov 15, 2021

When introducing TypeScript in a project I noticed the current documentation is still missing the mandatory step of including a tsconfig.json file in the project - without it the error "The 'files' list in config file 'tsconfig.json' is empty" occurs.

@iquito
Copy link
Contributor Author

iquito commented Nov 15, 2021

Targeting symfony:5.4 is probably incorrect, as this affects all versions of Webpack Encore that support TypeScript - although Webpack Encore does have a different versioning scheme than Symfony anyway, so I am not sure which version to target.

That a file tsconfig.json is necessary was not mentioned (without it the error "The 'files' list in config file 'tsconfig.json' is empty" occurs), and making it clear that it does not have to be in the main project folder seems helpful.
@javiereguiluz
Copy link
Member

Andreas, thanks and congrats on your first Symfony Docs contribution 🎉

You are right about versioning. We've merged in 4.4 and all the upper maintained branches. Thanks!

@iquito iquito deleted the patch-1 branch November 17, 2021 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants