Removing outdated jQuery note #16080
Conversation
form/form_collections.rst
Outdated
| @@ -305,17 +300,17 @@ you'll replace with a unique, incrementing number (e.g. ``task[tags][3][name]``) | |||
| const addFormToCollection = (e) => { | |||
| const collectionHolder = document.querySelector('.' + e.currentTarget.dataset.collectionHolderClass); | |||
|
|
|||
| const item = document.createElement('li'); | |||
| const element = document.createElement('li'); | |||
There was a problem hiding this comment.
Why not call the variable listItem everywhere instead?
| const element = document.createElement('li'); | |
| const listItem = document.createElement('li'); |
There was a problem hiding this comment.
Short answer: Cause it might also be a <div> (or whatever).
Long answer: I really like how @Oipnet in #15455 added the data-index attribute to Twig to get it out of JavaScript. So the only implementation-specific thing that's left in JavaScript is the HTML element to be added. I even thought about adding a data-element attribute for that... In the end, I just changed the variable name to something very generic :-)
|
Thank you @ThomasLandauer! Fyi, I've reverted some of the changes (e.g. I think "item" is generic enough already, while still giving some sort of idea if we're talking about the collection holder or a collection item). |
Looks like this was just forgotten at #15455
The other text I deleted merely repeated what has already been said above: