[Security] Added a note regarding the loginUser() method #16071
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
reviewed
Nov 28, 2021
OskarStark
reviewed
Nov 30, 2021
|
One test failed but I don't think it's related to the changes brought by this PR. |
HeahDude
suggested changes
Jul 16, 2022
artyuum
requested review from
HeahDude and
OskarStark
and removed request for
OskarStark and
HeahDude
xabbuh
approved these changes
Sep 2, 2022
|
Thanks @artyuum and I'm sorry it took us so long to merge this. |
|
No problem, thank you all for reviewing and merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @javiereguiluz stated, this method won't work for 100% of Symfony users. This is my case. I'm testing some protected API routes and the firewall is using a custom authenticator that relies on a custom header called "x-api-key". After spending hours trying to understand what I did wrong in my tests, I decided to dig into the code that defines the
loginUser()method and noticed that it can only work with session-based authentication.This little note could have saved me some time, so I believe it could help future users as well who are in the same case as me.