Skip to content

14123 Document denormalize groups value '*' #15909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2022
Merged

14123 Document denormalize groups value '*' #15909

merged 1 commit into from
Jul 22, 2022

Conversation

JohJohan
Copy link
Contributor

@JohJohan JohJohan commented Oct 10, 2021 •
edited
Loading

Fixes #14123.

@carsonbot carsonbot added this to the 5.4 milestone Oct 10, 2021
@JohJohan JohJohan changed the base branch from 5.4 to 5.2 October 10, 2021 18:34
@JohJohan JohJohan changed the title 14123 14123 [Serializer] Document denormalize groups value '*' Oct 10, 2021
@JohJohan JohJohan changed the title 14123 [Serializer] Document denormalize groups value '*' [Serializer] 14123 Document denormalize groups value '*' Oct 10, 2021
@JohJohan JohJohan mentioned this pull request Oct 12, 2021
Closed
tarlepp
tarlepp reviewed Jul 13, 2022
View reviewed changes
Copy link

@tarlepp tarlepp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me this looks just fine.

HeahDude
HeahDude approved these changes Jul 14, 2022
View reviewed changes
Copy link
Contributor

@HeahDude HeahDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Should target 5.4). Thank you for that PR!

@carsonbot carsonbot changed the title [Serializer] 14123 Document denormalize groups value '*' 14123 Document denormalize groups value '*' Jul 14, 2022
Ahummeling
Ahummeling approved these changes Jul 14, 2022
View reviewed changes
Copy link
Contributor

@Ahummeling Ahummeling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@JohJohan JohJohan changed the base branch from 5.2 to 5.4 July 14, 2022 18:30
@JohJohan
Copy link
Contributor Author

@HeahDude i changed target branch to 5.4

@javiereguiluz javiereguiluz merged commit fb9a7cd into symfony:5.4 Jul 22, 2022
@javiereguiluz
Copy link
Member

Thanks Johan! ... and sorry it took us so long to merge your contribution 🙏

@JohJohan
Copy link
Contributor Author

No worries! Just glad I can contribute a little :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarlepp tarlepp tarlepp left review comments

@HeahDude HeahDude HeahDude approved these changes

@Ahummeling Ahummeling Ahummeling approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.

[Serializer] Add special '*' serialization group that allows any group
6 participants
@JohJohan @javiereguiluz @tarlepp @HeahDude @Ahummeling @carsonbot