Update profiler.rst #15775
Merged
Update profiler.rst #15775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the getKernel() method is available in $event rather than $this. Perhaps a full event subscriber class could be included to make it more complete?
|
Good catch Eric! You are right that we could show the entire subscriber class ... but this is an advance article so hopefully most readers won't need that. We can revisit this in the future if we receive more feedback. About the upper branches, after merging your PR will "upmerge" it to all supported branches, so your fix will be everywhere without you having to do anything else. Thanks and congrats on your first Symfony Docs contribution 🎉 |
|
@javiereguiluz That was a quick reply! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the getKernel() method is available in $event rather than $this, however the $event->getKernel() refers to the \Symfony\Component\HttpKernel\HttpKernel which does not have the isDebug()-method.
Perhaps a full event subscriber class could be included to make it more complete?
Same problem applies on 5.3, 5.4 and 6.0 as well.