Adds proper escaping for php service config format #15766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
approved these changes
Aug 31, 2021
| @@ -67,7 +67,7 @@ to another service: ``App\Mailer``. One way to do this is with an expression: | |||
| $services->set(MailerConfiguration::class); | |||
|
|
|||
| $services->set(Mailer::class) | |||
| ->args([expr("service('App\\Mail\\MailerConfiguration').getMailerMethod()")]); | |||
| ->args([expr("service('App\\\\Mail\\\\MailerConfiguration').getMailerMethod()")]); | |||
There was a problem hiding this comment.
The result is so ugly and confusing, that we might think of adding a comment explaining this. Example:
$services->set(Mailer::class)
// because of the escaping applied by PHP, you must add 4 backslashes for each original backslash
->args([expr("service('App\\\\Mail\\\\MailerConfiguration').getMailerMethod()")]);
php configs need `\\\\`, `\\` are not enough.
`"service('App\\Mailer')"` compiles into `AppMailer` , `"service('App\\\\Mailer')"` compiles correctly into `App\Mailer`
javiereguiluz
force-pushed
the
patch-1
branch
from
c0334ad to
88c25e1
Compare
|
Faizan, thanks and congrats on your first Symfony Docs contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
php configs need
\\\\,\\are not enough."service('App\\Mailer')"compiles intoAppMailer,"service('App\\\\Mailer')"compiles correctly intoApp\Mailer