Skip to content

Deprecate getDoctrine() and dispatchMessage() shortcuts #15607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 10, 2021
Merged

Deprecate getDoctrine() and dispatchMessage() shortcuts #15607

merged 1 commit into from
Aug 10, 2021

Conversation

javiereguiluz
Copy link
Member

Fixes #15605.

@javiereguiluz javiereguiluz added this to the 5.4 milestone Aug 9, 2021
@javiereguiluz javiereguiluz requested a review from xabbuh as a code owner August 9, 2021 11:01
@javiereguiluz javiereguiluz mentioned this pull request Aug 9, 2021
Merged
javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this pull request Aug 9, 2021
@javiereguiluz
minor symfony#15609 Deprecate the get() and has() shortcuts of Abstra…
3fa34a9 
…ctController (javiereguiluz)

This PR was merged into the 5.4 branch.

Discussion
----------

Deprecate the get() and has() shortcuts of AbstractController

Fixes symfony#15606.

We've been promoting service injection for long, so there weren't many `get()` occurrences to fix and I couldn't find any `has()` occurrence from AbstractController.

This PR leaves a `get()` usage on purpose in the `doctrine.rst` article because it was removed in another PR: symfony#15607.

Commits
-------

901535c Deprecate the get() and has() shortcuts of AbstractController
@javiereguiluz javiereguiluz merged commit e316093 into symfony:5.4 Aug 10, 2021
@javiereguiluz javiereguiluz deleted the fix_15605 branch August 10, 2021 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh Awaiting requested review from xabbuh xabbuh is a code owner

Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.

Clarify goals of AbstractController
2 participants
@javiereguiluz @carsonbot