-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[Notifier] Add Documentation for Events #15597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
917dff9
to
449fe6f
Compare
I would rathee document it like workflow component events (sub part of doc and not new page) |
I guess we need to link your new page here https://symfony.com/doc/current/notifier.html#learn-more |
Thanks @welcoMattic, from what I understand the instruction
|
@javiereguiluz can you review this one please? I guess it's ok, but I'm not RST master 😄 |
notifier/events.rst
Outdated
$message = $event->getOriginalMessage(); | ||
|
||
// log something | ||
$this->logger(sprintf("The message has been successfully sent and have id: %s, $message->getMessageId()")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$this->logger(sprintf("The message has been successfully sent and have id: %s, $message->getMessageId()")); | |
$this->logger(sprintf('The message has been successfully sent and have id: %s, $message->getMessageId()')); |
addb23b
to
45ea4ac
Compare
45ea4ac
to
98270d1
Compare
Hello @OskarStark Thanks for the review and sorry for the delay I missed the notifications. |
friendly ping 👋 |
It took time, but here we go, this is in now. Thank you very much Smaine. |
I added a |
No worries @OskarStark and big Thanks for following 👍 |
I would like to add documentation for the events available in the Notifier, see #15589
I don't know if I have the good approach (create a specific page like for console events)