Skip to content

[Mercure] Invalid namespace and method name #15531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 17, 2021
Merged

[Mercure] Invalid namespace and method name #15531

merged 1 commit into from
Jul 17, 2021

Conversation

zspine
Copy link
Contributor

@zspine zspine commented Jul 16, 2021

No description provided.

@OskarStark OskarStark requested a review from wouterj July 17, 2021 06:44
@carsonbot carsonbot changed the title Invalid namespace and method name [Mercure] Invalid namespace and method name Jul 17, 2021
@OskarStark
Copy link
Contributor

cc @chalasr and @dunglas are you able to verify this PR?

@dunglas
Copy link
Member

dunglas commented Jul 17, 2021 •
edited
Loading

Good catch @zspine.
@OskarStark could you also merge #15460 at the same time? It also contains some fixes and is ready.

@OskarStark
Copy link
Contributor

In this case this should target 4.4 @dunglas ?

@dunglas
Copy link
Member

dunglas commented Jul 17, 2021

yes indeed

@OskarStark OskarStark added this to the 4.4 milestone Jul 17, 2021
@OskarStark OskarStark changed the base branch from 5.3 to 4.4 July 17, 2021 07:29
@OskarStark OskarStark requested a review from xabbuh as a code owner July 17, 2021 07:29
@OskarStark
Copy link
Contributor

Thanks M#3.

@OskarStark OskarStark merged commit 70ffa9b into symfony:4.4 Jul 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunglas dunglas dunglas approved these changes

@OskarStark OskarStark OskarStark approved these changes

@wouterj wouterj Awaiting requested review from wouterj

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Mercure Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@zspine @OskarStark @dunglas @carsonbot