Skip to content

[Config] [Configuration] Added a note about XML and PHP formats #15530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 20, 2021
Merged

[Config] [Configuration] Added a note about XML and PHP formats #15530

merged 1 commit into from
Jul 20, 2021

Conversation

javiereguiluz
Copy link
Member

Fixes #14793.

@javiereguiluz javiereguiluz added this to the 5.2 milestone Jul 16, 2021
@carsonbot carsonbot changed the title [Configuration] Added a note about XML and PHP formats [Config] [Configuration] Added a note about XML and PHP formats Jul 16, 2021
OskarStark
OskarStark requested changes Jul 17, 2021
View reviewed changes
Copy link
Contributor

@OskarStark OskarStark left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case this should target 5.2, right?

@javiereguiluz javiereguiluz changed the base branch from 5.4 to 5.2 July 20, 2021 11:37
@javiereguiluz
Copy link
Member Author

Good catch! Merged in 5.2 and up. Thanks!

@javiereguiluz javiereguiluz merged commit c60228f into symfony:5.2 Jul 20, 2021
@javiereguiluz javiereguiluz deleted the fix_14793 branch July 20, 2021 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark requested changes

Assignees
No one assigned
Labels
Config Status: Reviewed
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.

XML and PHP config not supported by Kernel by default
3 participants
@javiereguiluz @OskarStark @carsonbot