Skip to content

[Testing] use static::getContainer() #15487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 15, 2021
Merged

[Testing] use static::getContainer() #15487

merged 1 commit into from
Jul 15, 2021

Conversation

tcheuD
Copy link
Contributor

@tcheuD tcheuD commented Jul 5, 2021

@noniagriconomie noniagriconomie mentioned this pull request Jul 5, 2021
Closed
@tcheuD tcheuD mentioned this pull request Jul 9, 2021
Merged
@ker0x
Copy link
Contributor

ker0x commented Jul 9, 2021 •
edited
Loading

I think there are other references to self::$container or static::$container in the file that can be replaced too

@tcheuD
[Testing] use static::getContainer()
d72d610 
self::$container is deprecated since symfony5.3
@tcheuD
Copy link
Contributor Author

tcheuD commented Jul 10, 2021

I think there are other references to self::$container or static::$container in the file that can be replaced too

Done :)

@OskarStark
Copy link
Contributor

Thank you Damien.

@OskarStark OskarStark merged commit a246798 into symfony:5.3 Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

Assignees
No one assigned
Labels
Status: Reviewed Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tcheuD @ker0x @OskarStark @carsonbot