Skip to content

[Logger] Delete monolog_regex_based_excludes.rst #15465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 27, 2021

Conversation

ThomasLandauer
Copy link
Contributor

Since excluded_404s is deprecated in Monolog, I think this page can be deleted. Everything is said on https://symfony.com/doc/current/logging/monolog_exclude_http_codes.html

@carsonbot carsonbot changed the title Delete monolog_regex_based_excludes.rst [Logger] Delete monolog_regex_based_excludes.rst Jul 27, 2021
@javiereguiluz javiereguiluz added this to the 5.2 milestone Jul 27, 2021
Since `excluded_404s` is deprecated in Monolog, I think this page can be deleted. Everything is said on https://symfony.com/doc/current/logging/monolog_exclude_http_codes.html
@javiereguiluz javiereguiluz changed the base branch from 5.3 to 5.2 July 27, 2021 15:27
@javiereguiluz javiereguiluz requested a review from xabbuh as a code owner July 27, 2021 15:27
@javiereguiluz javiereguiluz merged commit 2d9c2a7 into symfony:5.2 Jul 27, 2021
@javiereguiluz
Copy link
Member

Thanks Thomas. We merged this in 5.2 and did some additional changes while merging (see 456ae42) which are needed when deleting contents. Cheers!

@ThomasLandauer ThomasLandauer deleted the patch-3 branch July 27, 2021 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants