Skip to content

fix(symfony-cli): remove APP_ENV=test behaviour with the database #15450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2021

Conversation

Kocal
Copy link
Member

@Kocal Kocal commented Jun 19, 2021

Our CI started to fail since the last Symfony CLI releases, because there is no APP_ENV=test behaviour with the database anymore with https://github.com/symfony/cli/releases/tag/v4.25.3 and/or https://github.com/symfony/cli/releases/tag/v4.25.4.

Looks like the solution is to do the same than symfony/recipes#939.

Our CI started to fail since the last Symfony CLI releases, because there is no APP_ENV=test behaviour with the database anymore with https://github.com/symfony/cli/releases/tag/v4.25.3 and/or https://github.com/symfony/cli/releases/tag/v4.25.2.

Looks like the solution is to do the same than symfony/recipes#939.
@carsonbot carsonbot added this to the 4.4 milestone Jun 19, 2021
@OskarStark
Copy link
Contributor

IIRC 4.25.4 fixes the issue

@Kocal
Copy link
Member Author

Kocal commented Jun 19, 2021

Sorry, I mean 4.25.3 and 4.25.4, not the 4.25.2! (op edited)

I've updated to 4.25.4 and APP_ENV=test symfony var:export does not suffix the database name with _test, the solution was to update the Doctrine Bundle to ^2.4 and use dbname_suffix in test environment.

@Kocal
Copy link
Member Author

Kocal commented Sep 26, 2021

Someone got an issue with APP_ENV=test behaviour with the database, see https://github.com/symfony/cli/issues/470

Friendly ping @javiereguiluz, thanks 🙏

@javiereguiluz
Copy link
Member

Thank you Hugo.

@javiereguiluz javiereguiluz merged commit 05c591e into symfony:4.4 Nov 6, 2021
@Kocal Kocal deleted the patch-3 branch November 6, 2021 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants