Skip to content

[Notifier] [Slack] Fixing use example #15409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 10, 2021
Merged

[Notifier] [Slack] Fixing use example #15409

merged 1 commit into from
Jun 10, 2021

Conversation

eesnaola
Copy link
Contributor

@eesnaola eesnaola commented Jun 5, 2021 •
edited
Loading

The right class is SlackImageBlockElement

@javiereguiluz
Copy link
Member

@OskarStark can you please review this proposal? In Symfony code there is both SlackImageBlock.php and SlackImageBlockElement.php (see https://github.com/symfony/slack-notifier/tree/5.3/Block) Thanks!

OskarStark
OskarStark approved these changes Jun 10, 2021
View reviewed changes
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix is correct, this class is a) used and b) is the correct one because its an image which is used inside a block 👍

@OskarStark OskarStark changed the title [Notifier] [Chatters] Fixing use example [Notifier] [Slack] Fixing use example Jun 10, 2021
@OskarStark OskarStark added this to the 5.3 milestone Jun 10, 2021
@OskarStark
Copy link
Contributor

Thank you Ezequiel.

@OskarStark OskarStark merged commit d2b7400 into symfony:5.3 Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

Assignees
No one assigned
Labels
Notifier Status: Reviewed
Projects
None yet
Milestone
5.3
Development

Successfully merging this pull request may close these issues.
4 participants
@eesnaola @javiereguiluz @OskarStark @carsonbot