-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[HttpClient] More on testing, how to test request, example #15385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hey, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great addition to the documentation! I'm proposing a few changes to make the description of why this is useful clearer; the rest is good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super useful addition, had to figure this stuff out myself, hope it gets merged soon 🙏 A few nitpicks on English, hope they're correct 😅
7a0f16e
to
c37b9f2
Compare
Thanks for suggestions - rebased the PR and applied them. |
c37b9f2
to
2c27ceb
Compare
@SirRFI thanks a lot for this contribution. It's now merged. For future contributions, please note that we prefer to not include full examples in Symfony Docs. We think those belong to blog posts and tutorials, whereas Symfony Docs should focus on showing each separate feature. Thanks! |
@javiereguiluz I'm sorry... but why? Why can't the docs have complete examples? Proper examples! More examples.... English is not the fist language of many of the devs (myself included) so sometimes things get lost in translation, but I can read the code and have a better understanding of how to use whatever thing from symfony I'm using. This merge is a perfect example, it was exactly what I was looking for, what I wanted to do but didn't know how and the docs didn't have any examples. It was @SirRFI that pointed me to the PR and saved the day. Is this to force people to go to symfony casts and similar websites? |
The reason is that full-length examples are much more complex to maintain. We don't have the resources to do that and sadly, we'll never have them. We can't keep with Symfony code pace (there are still many undocumented Symfony features) so just thinking about doing more things is wishful thinking. I guess you'll be disappointed, but I think it's better to be honest and explain the true reasons. |
Btw, feedback is always welcome. But you completely lost me when you started suggesting that a couple volunteers would make their work worse so that other services can be monetized. |
Why not just prefix the examples with the version? I understand that at the top you can select the version but something differs between minor versions just say: "This complex example is for version x.y.z". But if you can't keep up with symfony code, maybe put more links to those tutorials you mentioned? That might mitigate some of the symfony code issues. |
PR focused on HTTP Client's testing. Specifically: