Skip to content

[DependencyInjection] Remove a redundant table in DIC tags article #15374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 27, 2021
Merged

[DependencyInjection] Remove a redundant table in DIC tags article #15374

merged 1 commit into from
May 27, 2021

Conversation

javiereguiluz
Copy link
Member

If you look at https://symfony.com/doc/4.4/reference/dic_tags.html you see that:

  • Page already shows a clickable TOC with all the tags, so the table is not needed
  • The tag description in the table is repeated in each tag section (in the line called "Purpose"), so the table is not needed

@javiereguiluz javiereguiluz added this to the 4.4 milestone May 25, 2021
@javiereguiluz javiereguiluz merged commit 575dc20 into symfony:4.4 May 27, 2021
@javiereguiluz javiereguiluz deleted the redundant_table branch May 27, 2021 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxhelias maxhelias maxhelias approved these changes

Assignees
No one assigned
Labels
DependencyInjection Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
3 participants
@javiereguiluz @maxhelias @carsonbot