-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[Mailer] Added cautionbox for sender #15240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The original content might be not great ... but the proposed content doesn't look better in my opinion. It's harder to understand, at least to me. |
The original "Sender used by the Mailer" is ambiguous, as there are two things called "Sender":
The latter is sometimes called "envelope sender", but this only makes things worse, since for those who don't know, it's harder to find out what/where this "envelope" lives (correct answer: nowhere ;-) rather than find out what an SMTP session is - see also your #15241 (comment) :-) So I would suggest to avoid the term "envelope" completely, and even rename the configuration key at https://symfony.com/doc/current/mailer.html#configuring-emails-globally to something like |
TODO: Same for "recipients", line 3141
b202aa1
to
adba2b8
Compare
Thanks for the provided info Thomas. I've merged and tweaked it a bit to provide more details about which "sender" this is about. |
@javiereguiluz I can't figure out where I can see what you changed :-( Can you give me a hint? TODO: Same for "recipients", line 3141 |
This is the commit with the changes based on your extended comment: 05e1203 |
Follow-up of symfony#15240 This is the *full* SMTP session, not just the "establishment".
Thanks! Doesn't GitHub automatically link them somehow? Can't find "05e1203" on this Conversation page here... |
Second part of symfony#15240
TODO: Same for "recipients", line 3141