Skip to content

[Mailer] Added cautionbox for sender #15240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2021

Conversation

ThomasLandauer
Copy link
Contributor

TODO: Same for "recipients", line 3141

@carsonbot carsonbot changed the title Added cautionbox for sender [Mailer] Added cautionbox for sender Apr 21, 2021
@javiereguiluz
Copy link
Member

The original content might be not great ... but the proposed content doesn't look better in my opinion. It's harder to understand, at least to me.

@ThomasLandauer
Copy link
Contributor Author

The original "Sender used by the Mailer" is ambiguous, as there are two things called "Sender":

EHLO example.com
MAIL FROM: <me@example.com>
RCPT TO: <you@example.com>
DATA

The latter is sometimes called "envelope sender", but this only makes things worse, since for those who don't know, it's harder to find out what/where this "envelope" lives (correct answer: nowhere ;-) rather than find out what an SMTP session is - see also your #15241 (comment) :-)

So I would suggest to avoid the term "envelope" completely, and even rename the configuration key at https://symfony.com/doc/current/mailer.html#configuring-emails-globally to something like smtp

TODO: Same for "recipients", line 3141
@javiereguiluz javiereguiluz changed the base branch from 5.2 to 5.3 August 12, 2021 14:30
@javiereguiluz javiereguiluz merged commit 236ed26 into symfony:5.3 Aug 12, 2021
@javiereguiluz
Copy link
Member

Thanks for the provided info Thomas. I've merged and tweaked it a bit to provide more details about which "sender" this is about.

@ThomasLandauer
Copy link
Contributor Author

@javiereguiluz I can't figure out where I can see what you changed :-( Can you give me a hint?

TODO: Same for "recipients", line 3141

@javiereguiluz
Copy link
Member

This is the commit with the changes based on your extended comment: 05e1203

ThomasLandauer added a commit to ThomasLandauer/symfony-docs that referenced this pull request Aug 12, 2021
Follow-up of symfony#15240
This is the *full* SMTP session, not just the "establishment".
@ThomasLandauer
Copy link
Contributor Author

Thanks! Doesn't GitHub automatically link them somehow? Can't find "05e1203" on this Conversation page here...

ThomasLandauer added a commit to ThomasLandauer/symfony-docs that referenced this pull request Aug 12, 2021
@ThomasLandauer ThomasLandauer deleted the patch-13 branch August 12, 2021 15:27
javiereguiluz added a commit that referenced this pull request Aug 13, 2021
This PR was merged into the 5.3 branch.

Discussion
----------

[Mailer] Minor typos

Follow-up of #15240
This is the *full* SMTP session, not just the "establishment".

Commits
-------

6b69fe3 Minor typos
javiereguiluz added a commit that referenced this pull request Aug 13, 2021
This PR was merged into the 5.3 branch.

Discussion
----------

[Mailer] Fixing "envelope recipient"

Second part of #15240

The link `SMTP session` depends on #15616

Commits
-------

18fb7c3 Fixing "envelope recipient"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants