[Ldap] Update ldap.rst #15208
Merged
[Ldap] Update ldap.rst #15208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
reviewed
Apr 9, 2021
|
Is this code already available in Symfony 4.4? |
Using blame to look at /Adapter/ExtLdap/Query.php in the callSearchFunction line shows that there was a refactor on 2020-10-07, but that the code that was refactored had I'm seeing this as far back as 3 years ago, so I'm feeling like it was available in 4.4. |
|
Thanks for your feedback ✅ |
OskarStark
approved these changes
Apr 12, 2021
|
Jason, thanks a lot for adding these missing docs and for taking the time to investigate where should we merge this (we merged it in 4.4 and up). Also, congrats on your first Symfony Docs contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
include documentation of the filter option for the query command.