Skip to content

Encore: Update 'Fix "Invalid Host header" Issue'. #15090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 25, 2021

Conversation

marcstraube
Copy link
Contributor

Replace deprecated dev-server option "--disable-host-check" with current config.

@OskarStark OskarStark requested a review from weaverryan March 12, 2021 05:32
@carsonbot carsonbot changed the title Encore: Update 'Fix "Invalid Host header" Issue'. [Encore] Encore: Update 'Fix "Invalid Host header" Issue'. Mar 12, 2021
@carsonbot carsonbot changed the title [Encore] Encore: Update 'Fix "Invalid Host header" Issue'. Encore: Update 'Fix "Invalid Host header" Issue'. May 25, 2021
@javiereguiluz javiereguiluz added this to the 4.4 milestone May 25, 2021
@javiereguiluz
Copy link
Member

javiereguiluz commented May 25, 2021

Here we can see that it was deprecated: https://github.com/webpack/webpack-dev-server/blob/08a83a65f5c500a648c12faa2fa03122ee380c8b/CHANGELOG.md#400-beta0-2020-11-27

the disableHostCheck and allowedHosts options were removed in favor of the firewall option

And here we updated Symfony Docs with changes similar to this one: https://github.com/symfony/symfony-docs/pull/14895/files

So, let's merge this.

Thanks Marc and congrats on your first Symfony Docs contribution 🎉

@javiereguiluz javiereguiluz changed the base branch from 5.4 to 4.4 May 25, 2021 11:47
Replace deprecated dev-server option "--disable-host-check" with current config.
@javiereguiluz javiereguiluz requested a review from xabbuh as a code owner May 25, 2021 11:47
@javiereguiluz javiereguiluz force-pushed the devserver-disable-host-check branch from 12044ed to 15df424 Compare May 25, 2021 11:47
@javiereguiluz javiereguiluz merged commit a1fb993 into symfony:4.4 May 25, 2021
@marcstraube marcstraube deleted the devserver-disable-host-check branch May 25, 2021 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants