Distinct Bootstrap jQuery requirement #15073
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree with this. But Symfony does not support Bootstrap 5 yet. |
Add distinction to jQuery requirement for Bootstrap version 5, which does not require it to be used: https://getbootstrap.com/docs/5.0/getting-started/javascript/#still-want-to-use-jquery-its-possible
|
Thanks Christian, we've merged this with some minor tweaks. Tobias, you are right, but that should only affect you when trying to use a Form theme for Bootstrap 5 (there's none yet). But for the normal usage of Bootstrap 5 in Webpack Encore, it's OK to remind them to not use jQuery anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add distinction to jQuery requirement for Bootstrap version 5, which does not require it to be used:
https://getbootstrap.com/docs/5.0/getting-started/javascript/#still-want-to-use-jquery-its-possible
Text is a suggestion, I feel it could be more elegantly written?