[Cache] Remove compression option from Redis and Memcache
#15052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @Nyholm |
|
Maybe mention the BTW I've a doubt about memcache config also talking about compression. |
Sure!
You can use DeflateMarshaller for Memcache too. Or what are your doubts? |
|
I've a doubt about the memcache adapter documentation also talking about compression and I guess that if there is a global marshaller then individual adapter should not have compression option? |
|
FYI #15054 |
|
Oops, You are correct! Thank you for noticing. I've updated the PR |
Nyholm
changed the title
compressioncompression option from Redis and Memcache
OskarStark
approved these changes
Mar 3, 2021
javiereguiluz
force-pushed
the
redis-compression
branch
from
87e27fb to
b11322c
Compare
|
I wasn't aware of this! Thanks for removing these outdated docs. |
|
Thank you for the reviews and the merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option was removed in 4.4 because it didn't work.
See symfony/symfony#34133
This will fix #15050