[RateLimiter][Security] More precisely document advanced rate limiter configuration #15051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
changed the title
maxhelias
approved these changes
Mar 8, 2021
javiereguiluz
force-pushed
the
rate-limiter
branch
from
63f0f9d to
4933d45
Compare
|
Wouter, thanks for these nice additions! While merging I did some small rewords to turn passive voice into active voice ("locks are used by rate limiters ..." --> "rate limiters use locks ...") but the contents were perfect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These additions are based on questions I received from @Seldaek while he was trying out the login throttling feature on a more advanced high availability set-up.
Previously, we documented the happy-path, but were not so good at documenting the more advanced settings. This PR adds more detail about locks, storage and implementing your custom login rate limiter.