Skip to content

Minor change to use DateTimeImmutable instead of DateTime #15010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 22, 2021
Merged

Minor change to use DateTimeImmutable instead of DateTime #15010

merged 1 commit into from
Feb 22, 2021

Conversation

Erdou
Copy link
Contributor

@Erdou Erdou commented Feb 21, 2021

Using DateTimeImmutable instead of DateTime when no mutation is needed improves performances.

@javiereguiluz
Copy link
Member

I like this proposal. Thanks Erdal!

@Erdou @javiereguiluz
Minor change to use DateTimeImmutable instead of DateTime
8c6912b 
Using DateTimeImmutable instead of DateTime when no mutation is needed improves performances.
@javiereguiluz javiereguiluz changed the base branch from 5.x to 4.4 February 22, 2021 08:01
@javiereguiluz javiereguiluz merged commit 3b69d2a into symfony:4.4 Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Erdou @javiereguiluz @carsonbot