Skip to content

[Routing] Add PHP Attribute route example to the controller #15008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 22, 2021
Merged

[Routing] Add PHP Attribute route example to the controller #15008

merged 1 commit into from
Feb 22, 2021

Conversation

wkania
Copy link
Contributor

@wkania wkania commented Feb 20, 2021

No description provided.

@javiereguiluz
Copy link
Member

Nice! I love PHP attributes. Thanks!

@javiereguiluz javiereguiluz merged commit 9a37b34 into symfony:5.2 Feb 22, 2021
@wkania
Copy link
Contributor Author

wkania commented Feb 22, 2021

Yes, much better than the older solution; Which was code, in the docblocks!
Too bad there is no PHP RFC for nested attributes :(.

@OskarStark
Copy link
Contributor

Let's use it for some time and get a better feeling, I think it will be proposed some time 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

Assignees
No one assigned
Labels
Routing Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wkania @javiereguiluz @OskarStark @carsonbot