Skip to content

[HttpClient] Fix specifying http_version in YAML #14995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 18, 2021

Conversation

pableu
Copy link
Contributor

@pableu pableu commented Feb 17, 2021

With the code from the docs, I get this exception:

Unrecognized option "http_version" under "framework.http_client". Available options are "default_options", "enabled", "max_host_connections", "mock_response_factory", "scoped_clients".

Maybe the XML and PHP Annotation also needs a fix, but I don't feel confident doing that.

@carsonbot
Copy link
Collaborator

Hey!

Cool, it looks like you have quite a talent.

But you have made this PR towards a branch that is not maintained anymore. :/
Could you update the PR base branch to target one of these branches instead? 4.4, 5.2.

Cheers!

Carsonbot

@carsonbot carsonbot changed the title [HttpClient] Fix specifying http_version in YAML Fix specifying http_version in YAML Feb 17, 2021
@carsonbot carsonbot added this to the 5.1 milestone Feb 17, 2021
@pableu pableu changed the base branch from 5.1 to 5.2 February 17, 2021 15:24
@javiereguiluz javiereguiluz modified the milestones: 5.1, 5.2 Feb 17, 2021
@carsonbot carsonbot changed the title Fix specifying http_version in YAML [HttpClient] Fix specifying http_version in YAML Feb 18, 2021
@javiereguiluz javiereguiluz modified the milestones: 5.2, 4.4 Feb 18, 2021
@javiereguiluz
Copy link
Member

Pablo, thanks for fixing this bug! While merging we've updated the XML and PHP configs too. We merged it in 4.4 and all the upper branches. Thanks!

@pableu
Copy link
Contributor Author

pableu commented Feb 18, 2021

Cool, thanks for improving my fix 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants