[Testing] [PHPUnit-Bridge] Troubleshooting #14917
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sylfabre
force-pushed
the
phpunit_bridge
branch
2 times, most recently
from
ca960e1 to
b50238c
Compare
|
I don't understand what's wrong with https://github.com/symfony/symfony-docs/runs/1815088336?check_suite_focus=true It looks like the syntax I can find in other files like https://github.com/symfony/symfony-docs/blob/5.x/components/yaml.rst line 179 |
carsonbot
changed the title
javiereguiluz
force-pushed
the
phpunit_bridge
branch
from
b50238c to
8e162de
Compare
|
Thanks Sylvain! The reported error was about using We fixed that while merging this. Thanks! |
|
@javiereguiluz thank you for the merge and the explanation 👌 Do I need to submit a PR for 5.x too? Or does it gets merged "there" too? |
|
There's no need to submit PR for upper branches because we "upmerge" all PR in all supported branches. Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR documents a new solution to an issue I'm having with ClockMock related to https://bugs.php.net/bug.php?id=76788.
I was the original author of the current Troubleshooting section and came across another use-case