Skip to content

[Form] Update Type.rst #14899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 19, 2021
Merged

[Form] Update Type.rst #14899

merged 1 commit into from
Feb 19, 2021

Conversation

ntnchq
Copy link
Contributor

@ntnchq ntnchq commented Jan 29, 2021

Change ramsey uid implementation to symfony/uid.

@ntnchq ntnchq requested a review from xabbuh as a code owner January 29, 2021 00:05
@xabbuh xabbuh added this to the 5.2 milestone Jan 29, 2021
@carsonbot carsonbot changed the title Update Type.rst [Form] Update Type.rst Jan 29, 2021
@javiereguiluz
Copy link
Member

@nietonchique thanks for this contribution. The problem I see is that in newer Symfony versions there's a built-in way to use Symfony's UUID/ULID as ID generators and types, so this might be confusing (because it's unnecessary in those new Symfony apps).

We might want to update this example, but using a different example. Thanks.

Change Ramsey to symfony/uid
@javiereguiluz javiereguiluz changed the base branch from 5.2 to 4.4 February 19, 2021 16:27
@javiereguiluz javiereguiluz merged commit eda7791 into symfony:4.4 Feb 19, 2021
@javiereguiluz
Copy link
Member

Thank you @nietonchique. While merging we changed the example a bit because of the reasons explained in the previous comment. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants