Updating {% block javascripts position to match recipe change #14836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
commented
Jan 15, 2021
|
|
||
| The ``encore_entry_link_tags()`` comes from WebpackEncoreBundle and relies | ||
| on a feature in Encore that was first introduced in version 0.21.0. Previously, | ||
| the ``asset()`` function was used to point directly to the file. |
There was a problem hiding this comment.
The old note had probably been there long enough - so I just replaced it with the new one
2 tasks
OskarStark
reviewed
Jan 15, 2021
weaverryan
force-pushed
the
changing-javascripts-block-position
branch
from
c6e7b91 to
8c2c794
Compare
weaverryan
changed the title
|
This is now ready! |
OskarStark
approved these changes
Jan 15, 2021
|
I like this change Ryan! And the needed doc changes are small, so the transition will be smooth. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
See symfony/recipes#874
I did this against 4.4 (which is normally done for bug fixes) because this would appear as a "documentation bug" if we updated the recipe but didn't update the docs.
Thanks!