Mentioning "array" explicitly #14771
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See symfony#13996 (comment) - I opened that other PR to get the word **array** on the page ;-) Also, I'm deleting two comments `// ...` from code blocks, since they're present in some, and absent in some. I think it's better to omit them, if the given example is (sort of) complete in itself. IMO, these 2 deleted comments did't add any value, and just made the page longer.
|
Hi Thomas 👋 I am against merging this, we are explaining different ways to define recipients, and one should focus on that. Thank you for your contribution, feel free to reopen if you want to discuss this further 👍 Have a nice day! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #13996 (comment) - I opened that other PR to get the word array on the page ;-)
Also, I'm deleting two comments
// ...from code blocks, since they're present in some, and absent in some. I think it's better to always omit them, if the given example is (sort of) complete in itself. IMO, these 2 deleted comments didn't add any value, and just made the page longer.General question: How often are the pages rebuilt? Or what's the process of getting stuff online at https://symfony.com/doc/4.4/mailer.html#email-addresses after a PR has been merged?