[Form] Update rounding mode defintion integer type #14750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
force-pushed
the
update-rounding-mode-defintion-integer-type
branch
from
f82f972 to
3a7985f
Compare
carsonbot
changed the title
|
Very nice contribution @MrYamous! While merging we fixed the name of the Symfony class which defined the now deprecated constant aliases. We think it should be this one: https://github.com/symfony/symfony/blob/5.1/src/Symfony/Component/Form/Extension/Core/DataTransformer/NumberToLocalizedStringTransformer.php Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rounding_mode definition for IntegerType wasn't up to date after depreciation of
IntegerToLocalizedStringTransformer::ROUND_*constants