Skip to content

[Validator] Removing the recommended Constraints subdirectory #14621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 27, 2020

Conversation

ThomasLandauer
Copy link
Contributor

Since both the Constraint and the Validator are in the same directory, I can't see any reason for putting them into a subdirectory called Constraints. In other words: When keeping the Constraints subdirectory, what would be the recommended contents of the Validator directory?

  • If you agree in principle, I'll change the other occurrences too.
  • If you don't agree (i.e. want to keep the Constraints subdirectory), I suggest to rename it to Constraint, since all other directory names are singular too.

@xabbuh
Copy link
Member

xabbuh commented Nov 27, 2020

I do agree with these changes. At least that what I do in my applications too as the Validator namespace itself would otherwise be empty.

@carsonbot carsonbot changed the title Removing the recommended Constraints subdirectory [Validator] Removing the recommended Constraints subdirectory Nov 27, 2020
@javiereguiluz
Copy link
Member

It looks OK to me too 👍

@ThomasLandauer
Copy link
Contributor Author

I'm done :-)

@javiereguiluz
Copy link
Member

Thanks Thomas.

@javiereguiluz javiereguiluz merged commit da3163e into symfony:4.4 Nov 27, 2020
@ThomasLandauer ThomasLandauer deleted the patch-8 branch November 27, 2020 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants