Skip to content

[Doctrine] Add precision for doctrine lifecycle callbacks #14613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 25, 2020

Conversation

duboiss
Copy link
Contributor

@duboiss duboiss commented Nov 25, 2020

I think it's a good idea to specify that the methods must be public.

  • If the developer inadvertently makes the callable private, they will just realize that the method is not executed. No exceptions thrown.
  • By rereading the doc, it would be simpler for the word "public" to catch their attention.

@carsonbot carsonbot added this to the 4.4 milestone Nov 25, 2020
@carsonbot carsonbot changed the title Add precision for doctrine lifecycle callbacks [Doctrine] Add precision for doctrine lifecycle callbacks Nov 25, 2020
@javiereguiluz
Copy link
Member

I agree! This will make things easier to understand and will avoid confusion for some people. Thanks Steven and congrats on your first Symfony Docs contribution 🎉

@javiereguiluz javiereguiluz merged commit 019e0ac into symfony:4.4 Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants