Skip to content

[Form] Fixed the layout in the forms page #14589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 21, 2020
Merged

[Form] Fixed the layout in the forms page #14589

merged 1 commit into from
Nov 21, 2020

Conversation

TimoBakx
Copy link
Member

By moving the configuration tabs outside the versionadded block.

@TimoBakx
Copy link
Member Author

@wouterj, thanks for the feedback. I included all your suggestions.

@TimoBakx TimoBakx requested a review from wouterj November 21, 2020 20:10
@wouterj wouterj changed the base branch from 5.x to 5.2 November 21, 2020 22:08
wouterj added a commit that referenced this pull request Nov 21, 2020
@wouterj wouterj merged commit a27f5af into symfony:5.2 Nov 21, 2020
wouterj added a commit that referenced this pull request Nov 21, 2020
* 5.2:
  [#14589] Reworded form error messages paragraph
  [Form] Fixed the layout in the forms page by moving the configuration tabs outside the versionadded block.
@wouterj
Copy link
Member

wouterj commented Nov 21, 2020

Thank you! After merging, I reworded the paragraph a little bit in c4b9fc4 Please let me know if you disagree with the changes :)

@TimoBakx
Copy link
Member Author

Sounds good to me!

@TimoBakx TimoBakx deleted the fix-form-layout branch November 21, 2020 22:17
OskarStark added a commit that referenced this pull request Nov 25, 2020
* upstream/5.2:
  Fixed build
  [#14589] Reworded form error messages paragraph
  [Form] Fixed the layout in the forms page by moving the configuration tabs outside the versionadded block.
  Complete documentation about mailer integration
  Tweaks
  [Form] Documented legacy_error_messages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants