Skip to content

Document named arguments BC policy #14566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 20, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions contributing/code/bc.rst
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ backward compatibility promise:
+-----------------------------------------------+-----------------------------+
| Type hint against the interface | Yes |
+-----------------------------------------------+-----------------------------+
| Call a method | Yes |
| Call a method | Yes [10]_ |
+-----------------------------------------------+-----------------------------+
| **If you implement the interface and...** | **Then we guarantee BC...** |
+-----------------------------------------------+-----------------------------+
Expand Down Expand Up @@ -114,13 +114,13 @@ covered by our backward compatibility promise:
+-----------------------------------------------+-----------------------------+
| Access a public property | Yes |
+-----------------------------------------------+-----------------------------+
| Call a public method | Yes |
| Call a public method | Yes [10]_ |
+-----------------------------------------------+-----------------------------+
| **If you extend the class and...** | **Then we guarantee BC...** |
+-----------------------------------------------+-----------------------------+
| Access a protected property | Yes |
+-----------------------------------------------+-----------------------------+
| Call a protected method | Yes |
| Call a protected method | Yes [10]_ |
+-----------------------------------------------+-----------------------------+
| Override a public property | Yes |
+-----------------------------------------------+-----------------------------+
Expand Down Expand Up @@ -445,4 +445,8 @@ Turn static into non static No

.. [9] Allowed for the ``void`` return type.

.. [10] Parameter names are not part of the compatibility promise. Using
PHP 8's named arguments feature might break your code when upgrading to
newer Symfony versions.

.. _`Semantic Versioning`: https://semver.org/