Skip to content

Fixed broken use statements #14432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2020
Merged

Fixed broken use statements #14432

merged 1 commit into from
Oct 17, 2020

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Oct 16, 2020

Inspired by #14429 I decided to fix the other broken statements too.

wouterj
wouterj reviewed Oct 16, 2020
View reviewed changes
Copy link
Member

@wouterj wouterj left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you checking all examples! Is it maybe possible for you to split the ones I commented on, so that each fix ends up in the correct branch? 😬

@Nyholm Nyholm mentioned this pull request Oct 17, 2020
Merged
@javiereguiluz javiereguiluz added this to the 5.2 milestone Oct 17, 2020
javiereguiluz added a commit that referenced this pull request Oct 17, 2020
@javiereguiluz
minor #14433 Fixed use statement (Nyholm)
c6ec372 
This PR was merged into the 5.1 branch.

Discussion
----------

Fixed use statement

From #14432

Commits
-------

b513c15 Fixed use statement
@javiereguiluz
Copy link
Member

Super nice fixes! Thanks Tobias.

@javiereguiluz javiereguiluz merged commit dc08a5a into symfony:5.x Oct 17, 2020
xabbuh
xabbuh reviewed Oct 18, 2020
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz left review comments

@wouterj wouterj wouterj left review comments

@xabbuh xabbuh xabbuh left review comments

@HeahDude HeahDude Awaiting requested review from HeahDude

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.
5 participants
@Nyholm @javiereguiluz @wouterj @xabbuh @carsonbot