Skip to content

[RateLimiter] Adding docs for rate limit sliding window #14418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2020

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Oct 15, 2020

Does this makes sense? Do we understand how it works?

This will fix #14417

Copy link
Member

@wouterj wouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think it is. The idea of this document is to have something basic ready and then incrementally improve it.

E.g. I would love to have diagrams for each limiter showing the consequences (like the column images in https://medium.com/figma-design/an-alternative-approach-to-rate-limiting-f8a06cf7c94c [free medium article]). I think that should make things a lot clearer, but let's do it in a future PR

@javiereguiluz
Copy link
Member

Tobias, thanks for contributing this nice feature and for updating the docs too. Cheers!

@Nyholm
Copy link
Member Author

Nyholm commented Oct 17, 2020

Thank you for the review and merge.

@Nyholm Nyholm deleted the sliding-window branch October 17, 2020 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RateLimiter] Adding SlidingWindow algorithm
4 participants