Skip to content

Fix link to acquireRead #14406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 14, 2020
Merged

Fix link to acquireRead #14406

merged 1 commit into from
Oct 14, 2020

Conversation

l-vo
Copy link
Contributor

@l-vo l-vo commented Oct 13, 2020

Fix link to acquireRead: should target SharedLockInterface instead of LockInterface

@l-vo
Fix link to acquireRead
d243017 
Should target SharedLockInterface instead of LockInterface
Nyholm
Nyholm approved these changes Oct 13, 2020
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

This is to be merged in 5.x as it is new in 5.2.

@wouterj
Copy link
Member

wouterj commented Oct 14, 2020

Nice catch, thanks @l-vo!

@wouterj wouterj merged commit d139051 into symfony:5.x Oct 14, 2020
@l-vo l-vo deleted the patch-6 branch October 14, 2020 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nyholm Nyholm Nyholm approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@l-vo @wouterj @Nyholm @carsonbot