Skip to content

[Routing] Better use of composer require #14400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2020

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Oct 13, 2020

For Symfony 4.4

This will correct the mistake in #14387

If we still want to use the alias, please consider this PR: #14399

@xabbuh xabbuh added this to the 5.2 milestone Oct 13, 2020
wouterj added a commit that referenced this pull request Oct 14, 2020
…. (Nyholm)

This PR was submitted for the 5.x branch but it was merged into the 4.4 branch instead.

Discussion
----------

You need doctrine/annotations for route annotation support.

For Symfony 4.4

This will correct the mistake in #14387

There is an alternative to this PR here: #14400

Commits
-------

6a74ba6 You need doctrine/annotations for route annotation support.
@wouterj wouterj force-pushed the doctrine-annotation2 branch from ba1f6dd to 41b7983 Compare October 14, 2020 11:38
@wouterj
Copy link
Member

wouterj commented Oct 14, 2020

Thanks Tobias.

@wouterj wouterj merged commit 2cff7a4 into symfony:5.x Oct 14, 2020
@Nyholm
Copy link
Member Author

Nyholm commented Oct 14, 2020

Thank you for merging

@Nyholm Nyholm deleted the doctrine-annotation2 branch October 14, 2020 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants