Skip to content

Document Kernel::getBuildDir() #14378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 9, 2020
Merged

Document Kernel::getBuildDir() #14378

merged 1 commit into from
Oct 9, 2020

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Oct 9, 2020

noniagriconomie
noniagriconomie reviewed Oct 9, 2020
View reviewed changes
@Nyholm
Copy link
Member Author

Nyholm commented Oct 9, 2020

I updated the PR. I placed this section under "Cache Directory" now because $this->getCacheDir() is the default value and we refer to the read-write cache.

@javiereguiluz
Copy link
Member

Very nice contribution! Thanks Tobias.

@Nyholm
Copy link
Member Author

Nyholm commented Oct 9, 2020

Thank you. @noniagriconomie's reviews helped a lot =)

@javiereguiluz javiereguiluz merged commit 550dc8a into symfony:5.x Oct 9, 2020
@javiereguiluz javiereguiluz added this to the 5.2 milestone Oct 9, 2020
@noniagriconomie
Copy link
Contributor

@Nyholm it is much better imho, thx for taking into account my pov :)

@Nyholm Nyholm deleted the build-dir branch October 9, 2020 12:15
@mnapoli
Copy link
Contributor

mnapoli commented Oct 9, 2020

Thanks @Nyholm for all these docs PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noniagriconomie noniagriconomie noniagriconomie left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.

[HttpKernel] Add $kernel->getBuildDir() to separate it from the cache…
4 participants
@Nyholm @javiereguiluz @noniagriconomie @mnapoli