Missing Namespace from event dispatcher #14344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxhelias
approved these changes
Oct 5, 2020
|
I missed, it should be in 4.4 |
|
It is correct, but will not add so much additional value, its mostly clear through the filepath, I am against this change, sorry. |
|
I add this because many page have and don't have namespace or filepath. |
|
I am in favor of this kind of addition and making it uniform over the examples. This allows the beginner to have a better reference in their project |
|
We discussed this in the team and I agree this is helpful for beginners 👍 |
OskarStark
force-pushed
the
fix_wording/event_dispatcher
branch
from
95ae221 to
1e202b8
Compare
|
Thank you Gary. |
|
Thanks you @OskarStark |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.