Mention COMPOSE_FILE and COMPOSE_PROJECT_NAME #14264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fabpot could you please review these proposed changes? Thanks! |
fabpot
approved these changes
Oct 8, 2020
setup/symfony_server.rst
Outdated
| @@ -357,6 +357,25 @@ When Docker services are running, browse a page of your Symfony application and | |||
| check the "Symfony Server" section in the web debug toolbar; you'll see that | |||
| "Docker Compose" is "Up". | |||
|
|
|||
| If your Docker Compose file is not at the root of the project you can pass that information | |||
setup/symfony_server.rst
Outdated
| @@ -357,6 +357,25 @@ When Docker services are running, browse a page of your Symfony application and | |||
| check the "Symfony Server" section in the web debug toolbar; you'll see that | |||
| "Docker Compose" is "Up". | |||
|
|
|||
| If your Docker Compose file is not at the root of the project you can pass that information | |||
| to the Symfony Server. It works exactly as docker-compose. | |||
There was a problem hiding this comment.
exactly the same as for docker-compose
There was a problem hiding this comment.
I put the double tick here too. Done
setup/symfony_server.rst
Outdated
| If your Docker Compose file is not at the root of the project you can pass that information | ||
| to the Symfony Server. It works exactly as docker-compose. | ||
|
|
||
| Let's say you have your `docker-compose.yaml` file under a `docker/` directory. |
|
I made the changes @fabpot. Thanks |
fabpot
reviewed
Oct 8, 2020
setup/symfony_server.rst
Outdated
| If your Docker Compose file is not at the root of the project, you can pass that information | ||
| to the Symfony Server. It works exactly the same as for ``docker-compose``. | ||
|
|
||
| Let's say you have your ```docker-compose.yaml`` file under a ```docker/`` directory. |
There was a problem hiding this comment.
You have used triple ticks here twice :)
fabpot
reviewed
Oct 8, 2020
setup/symfony_server.rst
Outdated
|
|
||
| COMPOSE_FILE=docker/docker-compose.yaml COMPOSE_PROJECT_NAME=project_name docker-compose up -d | ||
|
|
||
| And if you are using the same env variables with the Symfony CLI, things will work. For instance: |
Plopix
commented
Oct 8, 2020
setup/symfony_server.rst
Outdated
|
|
||
| COMPOSE_FILE=docker/docker-compose.yaml COMPOSE_PROJECT_NAME=project_name symfony var:export | ||
|
|
||
| If you have more than one docker-compose files you can provide them all separated by `:` |
There was a problem hiding this comment.
should it be double ticks too here?
There was a problem hiding this comment.
I did, I think I had to.
maxhelias
approved these changes
Oct 9, 2020
|
Sébastien thanks for this contribution! (and thanks to reviewers too). Please note that we reword some bits while merging to make the explanation a bit more concise. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/symfony/cli/issues/323