[HttpClient] Add documentation for Retryable client #14253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jderusse
changed the title
jderusse
force-pushed
the
retry-client
branch
from
cb3a7b8 to
9d972e2
Compare
OskarStark
reviewed
Sep 17, 2020
jderusse
force-pushed
the
retry-client
branch
from
9d972e2 to
5b3a13b
Compare
jderusse
commented
Oct 2, 2020
| $client = new RetryableHttpClient(HttpClient::create()); | ||
|
|
||
| The ``RetryableHttpClient`` uses a | ||
| :class:`Symfony\\Component\\HttpClient\\Retry\\RetryDeciderInterface` to |
There was a problem hiding this comment.
Do you think we need a section to explain how user can implement their own Decider and BackOff ?
There was a problem hiding this comment.
It's not necessary because we no longer document components on its own, but when used inside a Symfony app. Thanks!
|
Jérémy, thanks a lot for implementing this feature and contributing its docs. We've just merged. We did some rewords to explain first the integration with Symfony and we added the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14252, #14317