Update http_client.rst : standalone HttpClient max host connections param #14236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
added
HttpClient
Status: Reviewed
and removed
Status: Needs Review
labels
|
Good catch Youssef! This is true since Symfony 4.4 (see https://github.com/symfony/symfony/blob/e368bb4517ee53c28c7f36bd4566168df2212a1f/src/Symfony/Component/HttpClient/HttpClient.php#L30) so we're merging this in 4.4 and upper branches. Thanks! |
javiereguiluz
force-pushed
the
patch-3
branch
from
4bdc53d to
70944d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the signature of
createmethod :public static function create(array $defaultOptions = [], int $maxHostConnections = 6, int $maxPendingPushes = 50): HttpClientInterfaceThe max host connection should be passed as the second param to this method instead of an option.