Skip to content

Add a link to the "real" component overview on the component index page #14196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 8, 2020

Conversation

wouterj
Copy link
Member

@wouterj wouterj commented Sep 7, 2020

As suggested in #14194 (comment)

@javiereguiluz if I'm correct, the "docs" link on the component overview page is customizable (i.e. Notifier is linking to the guide and not the component docs). Would it be a good idea to do the same for components that are already moved to guide-only mode (e.g. translation and routing) - to avoid weird redirects? Or remove the docs link completely for these components (e.g. all polyfills)?

@javiereguiluz
Copy link
Member

Thanks Wouter!

About the requested changes, you are right. I've created an issue in the private symfony.com repo to not forget about that.

@javiereguiluz javiereguiluz merged commit 528efdd into 4.4 Sep 8, 2020
@javiereguiluz javiereguiluz deleted the wouterj-patch-1 branch September 8, 2020 11:48
@javiereguiluz
Copy link
Member

I was wrong. These links can be updated publicly. I'm doing that in symfony/marketing#517

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants