Fix bad example of lock #14179
Merged
Fix bad example of lock #14179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jérémy you are right that we want to minimize the merges in 3.4 because we're just weeks away from its end of support. But precisely PRs like yours, which fix a clear bug, are the only ones which we still want to merge in 3.4. So, this was merged in 3.4. Thanks! |
javiereguiluz
force-pushed
the
lock-example
branch
from
4dc7c1b to
5233c2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just realized that example in lock were BAD. If you don't check the return of
$lock->acquire()you don't know if the lock has been acquiredPR against 4.4 because currently maintained, but bug exists since 3.4