[Workflow] pass arguments to getMetadata method #14151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
reviewed
Sep 1, 2020
xabbuh
approved these changes
Sep 2, 2020
|
I like this a lot! Thanks @lubo13 and congrats on your first Symfony Docs contribution! (please note that we've made some rewords while merging and we've merged this in 4.4, 5.1 and master branches, which are the supported ones). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By my opinion and the code in a trait, I saw that to the getMetadata method we should pass two arguments. But the first should be the key from metadata and the second should be null (for workflow's metadata), string (for place's metadata) or instance of Transition (for transition's metadata)