Some fixes in structure overriding page #14147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use `default_path` instead of `paths` to change translation directory (default_path is anyway added to paths) * Replace `var` by `vendor` in the public directory section
l-vo
force-pushed
the
use_translation_default_path_to_change_directory_structure
branch
from
cc9376c to
b65212f
Compare
|
Hi @l-vo! I was about to merge this PR, but I'm a bit confused by the target branch. If I understand symfony/symfony#24860 correctly, this option is introduced in Symfony 3.4, is there a reason you submitted this to 4.4? |
|
Hi @wouterj, you're right, it seems I made a mistake, I think it's because the second fix ( |
wouterj
added
Status: Reviewed
and removed
Status: Needs Review
Waiting feedback
labels
|
Ah, that makes sense. Thanks for your quick research today & proposing this fix a couple weeks ago, Laurent! |
l-vo
deleted the
use_translation_default_path_to_change_directory_structure
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
default_pathinstead ofpathsto change translation directory (default_path is anyway added to paths)varbyvendorin the public directory section (I think it's a typo, I don't see whyvarwould be involved when public dir is customized)In the same way, a #14135 targets 3.4 to use
default_pathinstead ofpathsfor templates.