Skip to content

Update pull_requests.rst #14115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 26, 2020
Merged

Update pull_requests.rst #14115

merged 1 commit into from
Aug 26, 2020

Conversation

noniagriconomie
Copy link
Contributor

Fix #14113

@noniagriconomie noniagriconomie changed the base branch from 5.1 to master August 22, 2020 09:21
@noniagriconomie noniagriconomie force-pushed the patch-11 branch 2 times, most recently from 581a70a to 066dd59 Compare August 22, 2020 09:27
@OskarStark
Copy link
Contributor

Could you please add a versionadded directive?

@noniagriconomie
Copy link
Contributor Author

noniagriconomie commented Aug 26, 2020 •
edited
Loading

@OskarStark the code PR is going to be backported is backported on 3.4 (symfony/symfony#37952)

so maybe i will rebase on 3.4, and i will add it at this moment :)

@OskarStark OskarStark self-assigned this Aug 26, 2020
@OskarStark OskarStark changed the base branch from master to 3.4 August 26, 2020 08:35
@OskarStark
Copy link
Contributor

Thank you Antoine.

@OskarStark OskarStark merged commit 6f27e88 into symfony:3.4 Aug 26, 2020
@noniagriconomie noniagriconomie deleted the patch-11 branch August 26, 2020 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeahDude HeahDude Awaiting requested review from HeahDude

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees

@OskarStark OskarStark

Labels
Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve link script with rollback when using symlink
3 participants
@noniagriconomie @OskarStark @carsonbot