[Translation] The 'other' key is mandatory in ICU 'select' #14072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a new Symfony app I worked on recently, we use ICU intl messages. Symfony makes it super easy to use and everything works perfectly. Thanks to everybody who made it possible!
However, when using
select, theotherkey is mandatory. In some messages of my app we only have two options, so I didn't addotherat first ... and I saw this:This option being mandatory is mentioned in http://userguide.icu-project.org/formatparse/messages and https://messageformat.github.io/messageformat/page-guide#toc3__anchor so we may do the same.